Comments on: New things are always better?

By: Thomas Guest

Thomas Guest — Fri, 10 Oct 2008 10:59:30 +0000

I’m with you on this one. I’d prefer a more functional style but sometimes it’s just too clumsy in C++, and sometimes I can’t figure out the right combination of standard functors and adaptors.

One tweak I would use here is to avoid breaking out of the loop.

while (s != e && std::isdigit( *s, classic ) )
{
++s;
}

By: hashpling

hashpling — Thu, 09 Oct 2008 20:04:18 +0000

Hmmm… good question. I think I’d go with the second version. I like the begin/end iterator style idiom but I find that once ‘bind’ starts getting involved some clarity is lost.

One big minus of the first implementation is that the result might depend on whether setlocale has been called earlier in the program and if so, it might also depend on the user and system environment.

By: Thomas Guest

Thomas Guest — Thu, 09 Oct 2008 07:12:42 +0000

Ouch! But seriously, which implementation do you prefer, and why?